This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Deduplicate plugin registration logic and make error logs visible #25297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
changed the title
xster
changed the title
gaaclarke
approved these changes
Mar 30, 2021
| Log.e( | ||
| TAG, | ||
| // getCause here because the first layer of the exception would be from reflect. | ||
| "Received exception while registering: " + e.getCause()); |
Member
There was a problem hiding this comment.
It would be nice if we could print out the name of the plugin that created the problem too.
Member
Author
There was a problem hiding this comment.
Ya, I'd like to buff up the actual content of the method being called by reflection too. Though that's in the flutter/flutter repo (that Java file is made by flutter_tools). Right now, I think it does state which plugin caused the problem (in the exception call stack which has the plugin's package name in it).
xster
added
the
waiting for tree to go green
fluttergithubbot
pushed a commit
that referenced
this pull request
Apr 2, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help make bugs like flutter/flutter#78625 a bit more obvious
Fixes flutter/flutter#74646